Re: [PATCH v4 04/52] scripts: kernel-doc: make it more compatible with Sphinx 3.x

[Jonathan Corbet]

On Wed, 30 Sep 2020 15:24:27 +0200
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote:

> With Sphinx 3.x, the ".. c:type:" tag was changed to accept either:
> 
> 	.. c:type:: typedef-like declaration
> 	.. c:type:: name
> 
> Using it for other types (including functions) don't work anymore.
> 
> So, there are newer tags for macro, enum, struct, union, and others,
> which doesn't exist on older versions.
> 
> Add a check for the Sphinx version and change the produced tags
> accordingly.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> ---
>  scripts/kernel-doc | 71 ++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 65 insertions(+), 6 deletions(-)

So this seems generally good, but I do wonder if we shouldn't just pass
the sphinx version into kernel-doc as a parameter?  We're already doing a
version check in the makefile, we should be able to capture the result and
pass it in, maybe?  

jon