Re: [PATCH net-next v2] net: dsa: Support bridge 802.1Q while untagging

From: Vladimir Oltean
Date: Thu Oct 01 2020 - 19:52:03 EST


On Thu, Oct 01, 2020 at 04:48:43PM -0700, Florian Fainelli wrote:
> > - move dsa_untag_bridge_pvid() after eth_type_trans(), similar to what
> > you did in your initial patch - maybe this is the cleanest
>
> This would be my preference and it would not be hurting the fast-path that
> much.

Ok, let's do that. You can also replace the hdr->h_vlan_proto with
skb->protocol in that case, and remove this:

struct vlan_ethhdr *hdr = vlan_eth_hdr(skb);

Thanks!
-Vladimir