Re: [PATCH] MIPS: cevt-r4k: Enable intimer for Loongson64 CPUs with extimer

From: Thomas Bogendoerfer
Date: Fri Oct 02 2020 - 09:38:54 EST


On Wed, Sep 23, 2020 at 07:02:54PM +0800, Jiaxun Yang wrote:
>
> +#ifdef CONFIG_CPU_LOONGSON64
> +static int c0_compare_int_enable(struct clock_event_device *cd)
> +{
> + if (cpu_has_extimer)
> + set_c0_config6(LOONGSON_CONF6_INTIMER);

why are you not simply do this in loognson64 board setup code and avoid
the whole cluttering of #ifdef CONFIG_CPU_LOONGSON64 over common code ?

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]