Re: [PATCH 2/2] PM/hibernate: remove the bogus call to get_gendisk in software_resume
From: Rafael J. Wysocki
Date: Fri Oct 02 2020 - 10:11:45 EST
On Fri, Oct 2, 2020 at 8:50 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Wed, Sep 30, 2020 at 05:45:27PM +0200, Rafael J. Wysocki wrote:
> > On Fri, Sep 25, 2020 at 6:15 PM Christoph Hellwig <hch@xxxxxx> wrote:
> > >
> > > get_gendisk grabs a reference on the disk and file operation, so this
> > > code will leak both of them while having absolutely no use for the
> > > gendisk itself.
> > >
> > > This effectively reverts commit 2df83fa4bce421f
> > > ("PM / Hibernate: Use get_gendisk to verify partition if resume_file is integer format")
> > >
> > > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> >
> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Can you pick it up through the PM tree? The big rework in this area
> I have planned won't land before 5.11 anyway.
Will do, thanks!