Re: [PATCH 5/9] sched/hotplug: Consolidate task migration on CPU unplug

From: Peter Zijlstra
Date: Fri Oct 02 2020 - 10:17:29 EST


On Thu, Oct 01, 2020 at 06:12:30PM +0100, Vincent Donnefort wrote:
> On Mon, Sep 21, 2020 at 06:36:02PM +0200, Peter Zijlstra wrote:
>
> [...]
>
> > +
> > + [CPUHP_AP_SCHED_WAIT_EMPTY] = {
> > + .name = "sched:waitempty",
> > + .startup.single = NULL,
> > + .teardown.single = sched_cpu_wait_empty,
> > + },
> > +
> > /* Handle smpboot threads park/unpark */
>
> Unless I missed something, now that the wait has its own HP step, this
> patch can probably also get rid of the balance_hotplug_wait() in
> sched_cpu_deactivate() introduced by:
>
> [PATCH 4/9] sched/core: Wait for tasks being pushed away on hotplug

I'd think so. Consider it gone.