Re: [RFC PATCH 22/22] x86/fpu/xstate: Introduce boot-parameters for control some state component support

From: Dave Hansen
Date: Fri Oct 02 2020 - 13:25:16 EST


On 10/1/20 1:39 PM, Chang S. Bae wrote:
> + if ((custom & XFEATURE_MASK_XTILE) != XFEATURE_MASK_XTILE) {
> + pr_warn("x86/fpu: Disable 0x%x components due to incorrect setup\n",
> + XFEATURE_MASK_XTILE);
> + custom &= ~(XFEATURE_MASK_XTILE);
> + }

Saying "incorrect setup" is pretty much just wasting the bytes. We
might as well just say "disabling due to random error", or "disabling
due to the easter bunny". Each are equally actionable. How about:

"error in xstate.disable parameter. Additionally disabling '%s'".