Re: [PATCH v2 3/4] arm: dts: add Alfa Network AP120C-AC
From: Robert Marko
Date: Fri Oct 02 2020 - 13:40:37 EST
On Wed, Sep 9, 2020 at 9:56 PM Robert Marko <robert.marko@xxxxxxxxxx> wrote:
>
> ALFA Network AP120C-AC is a dual-band ceiling AP, based on Qualcomm
> IPQ4018 + QCA8075 platform.
>
> Specification:
>
> - Qualcomm IPQ4018 (717 MHz)
> - 256 MB of RAM (DDR3)
> - 16 MB (SPI NOR) + 128 or 512 MB (SPI NAND) of flash
> - 2x Gbps Ethernet, with 802.3af PoE support in one port
> - 2T2R 2.4/5 GHz (IPQ4018), with ext. FEMs (QFE1952, QFE1922)
> - 3x U.FL connectors
> - 1x 1.8 dBi (Bluetooth) and 2x 3/5 dBi dual-band (Wi-Fi) antennas
> - Atmel/Microchip AT97SC3205T TPM module (I2C bus)
> - TI CC2540 Bluetooth LE module (USB 2.0 bus)
> - 1x button (reset)
> - 1x USB 2.0
> - DC jack for main power input (12 V)
> - UART header available on PCB (2.0 mm pitch)
>
> This adds DTS for both the generic and custom Bit edition for Sartura.
>
> Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> Cc: Luka Perkov <luka.perkov@xxxxxxxxxx>
> ---
> Changes since v1:
> * Drop include that does not exist
>
> arch/arm/boot/dts/Makefile | 2 +
> .../boot/dts/qcom-ipq4018-ap120c-ac-bit.dts | 28 ++
> arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts | 27 ++
> arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 254 ++++++++++++++++++
> 4 files changed, 311 insertions(+)
> create mode 100644 arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts
> create mode 100644 arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts
> create mode 100644 arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 9b474208057d..246d82fc5fcd 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -890,6 +890,8 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-apq8074-dragonboard.dtb \
> qcom-apq8084-ifc6540.dtb \
> qcom-apq8084-mtp.dtb \
> + qcom-ipq4018-ap120c-ac.dtb \
> + qcom-ipq4018-ap120c-ac-bit.dtb \
> qcom-ipq4018-jalapeno.dtb \
> qcom-ipq4019-ap.dk01.1-c1.dtb \
> qcom-ipq4019-ap.dk04.1-c1.dtb \
> diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts
> new file mode 100644
> index 000000000000..028ac8e24797
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +
> +#include "qcom-ipq4018-ap120c-ac.dtsi"
> +
> +/ {
> + model = "ALFA Network AP120C-AC Bit";
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + power {
> + label = "ap120c-ac:green:power";
> + gpios = <&tlmm 5 GPIO_ACTIVE_LOW>;
> + default-state = "on";
> + };
> +
> + wlan {
> + label = "ap120c-ac:green:wlan";
> + gpios = <&tlmm 3 GPIO_ACTIVE_HIGH>;
> + };
> +
> + support {
> + label = "ap120c-ac:green:support";
> + gpios = <&tlmm 2 GPIO_ACTIVE_HIGH>;
> + panic-indicator;
> + };
> + };
> +};
> diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts
> new file mode 100644
> index 000000000000..b7916fc26d68
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts
> @@ -0,0 +1,27 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +
> +#include "qcom-ipq4018-ap120c-ac.dtsi"
> +
> +/ {
> + leds {
> + compatible = "gpio-leds";
> +
> + status: status {
> + label = "ap120c-ac:blue:status";
> + gpios = <&tlmm 5 GPIO_ACTIVE_LOW>;
> + default-state = "keep";
> + };
> +
> + wlan2g {
> + label = "ap120c-ac:green:wlan2g";
> + gpios = <&tlmm 3 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "phy0tpt";
> + };
> +
> + wlan5g {
> + label = "ap120c-ac:red:wlan5g";
> + gpios = <&tlmm 2 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "phy1tpt";
> + };
> + };
> +};
> diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> new file mode 100644
> index 000000000000..1f3b1ce82108
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> @@ -0,0 +1,254 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +
> +#include "qcom-ipq4019.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> + model = "ALFA Network AP120C-AC";
> + compatible = "alfa-network,ap120c-ac";
> +
> + keys {
> + compatible = "gpio-keys";
> +
> + reset {
> + label = "reset";
> + gpios = <&tlmm 63 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_RESTART>;
> + };
> + };
> +};
> +
> +&tlmm {
> + i2c0_pins: i2c0_pinmux {
> + mux_i2c {
> + function = "blsp_i2c0";
> + pins = "gpio58", "gpio59";
> + drive-strength = <16>;
> + bias-disable;
> + };
> + };
> +
> + mdio_pins: mdio_pinmux {
> + mux_mdio {
> + pins = "gpio53";
> + function = "mdio";
> + bias-pull-up;
> + };
> +
> + mux_mdc {
> + pins = "gpio52";
> + function = "mdc";
> + bias-pull-up;
> + };
> + };
> +
> + serial0_pins: serial0_pinmux {
> + mux_uart {
> + pins = "gpio60", "gpio61";
> + function = "blsp_uart0";
> + bias-disable;
> + };
> + };
> +
> + spi0_pins: spi0_pinmux {
> + mux_spi {
> + function = "blsp_spi0";
> + pins = "gpio55", "gpio56", "gpio57";
> + drive-strength = <12>;
> + bias-disable;
> + };
> +
> + mux_cs {
> + function = "gpio";
> + pins = "gpio54", "gpio4";
> + drive-strength = <2>;
> + bias-disable;
> + output-high;
> + };
> + };
> +
> + usb-power {
> + line-name = "USB-power";
> + gpios = <1 GPIO_ACTIVE_HIGH>;
> + gpio-hog;
> + output-high;
> + };
> +};
> +
> +&watchdog {
> + status = "okay";
> +};
> +
> +&prng {
> + status = "okay";
> +};
> +
> +&blsp_dma {
> + status = "okay";
> +};
> +
> +&blsp1_i2c3 {
> + status = "okay";
> +
> + pinctrl-0 = <&i2c0_pins>;
> + pinctrl-names = "default";
> +
> + tpm@29 {
> + compatible = "atmel,at97sc3204t";
> + reg = <0x29>;
> + };
> +};
> +
> +&blsp1_spi1 {
> + status = "okay";
> +
> + pinctrl-0 = <&spi0_pins>;
> + pinctrl-names = "default";
> + cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>, <&tlmm 4 GPIO_ACTIVE_HIGH>;
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <24000000>;
> +
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition@0 {
> + label = "SBL1";
> + reg = <0x00000000 0x00040000>;
> + read-only;
> + };
> +
> + partition@40000 {
> + label = "MIBIB";
> + reg = <0x00040000 0x00020000>;
> + read-only;
> + };
> +
> + partition@60000 {
> + label = "QSEE";
> + reg = <0x00060000 0x00060000>;
> + read-only;
> + };
> +
> + partition@c0000 {
> + label = "CDT";
> + reg = <0x000c0000 0x00010000>;
> + read-only;
> + };
> +
> + partition@d0000 {
> + label = "DDRPARAMS";
> + reg = <0x000d0000 0x00010000>;
> + read-only;
> + };
> +
> + partition@e0000 {
> + label = "u-boot-env";
> + reg = <0x000e0000 0x00010000>;
> + };
> +
> + partition@f0000 {
> + label = "u-boot";
> + reg = <0x000f0000 0x00080000>;
> + read-only;
> + };
> +
> + partition@170000 {
> + label = "ART";
> + reg = <0x00170000 0x00010000>;
> + read-only;
> + };
> +
> + partition@180000 {
> + label = "priv_data1";
> + reg = <0x00180000 0x00010000>;
> + read-only;
> + };
> +
> + partition@190000 {
> + label = "priv_data2";
> + reg = <0x00190000 0x00010000>;
> + read-only;
> + };
> + };
> + };
> +
> + nand@1 {
> + compatible = "spi-nand";
> + reg = <1>;
> + spi-max-frequency = <40000000>;
> +
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition@0 {
> + label = "ubi1";
> + reg = <0x00000000 0x04000000>;
> + };
> +
> + partition@4000000 {
> + label = "ubi2";
> + reg = <0x04000000 0x04000000>;
> + };
> + };
> + };
> +};
> +
> +&blsp1_uart1 {
> + status = "okay";
> +
> + pinctrl-0 = <&serial0_pins>;
> + pinctrl-names = "default";
> +};
> +
> +&cryptobam {
> + status = "okay";
> +};
> +
> +&crypto {
> + status = "okay";
> +};
> +
> +&mdio {
> + status = "okay";
> +
> + pinctrl-0 = <&mdio_pins>;
> + pinctrl-names = "default";
> +};
> +
> +&wifi0 {
> + status = "okay";
> +};
> +
> +&wifi1 {
> + status = "okay";
> + qcom,ath10k-calibration-variant = "ALFA-Network-AP120C-AC";
> +};
> +
> +&usb3_hs_phy {
> + status = "okay";
> +};
> +
> +&usb3 {
> + status = "okay";
> +
> + dwc3@8a00000 {
> + phys = <&usb3_hs_phy>;
> + phy-names = "usb2-phy";
> + };
> +};
> +
> +&usb2_hs_phy {
> + status = "okay";
> +};
> +
> +&usb2 {
> + status = "okay";
> +};
> --
> 2.26.2
>
Hi,
Is there an issue with the patch preventing the review?
Regards,
Robert