Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized

[John Donnelly]

> On Oct 2, 2020, at 1:01 PM, Mike Christie <michael.christie@xxxxxxxxxx> wrote:
> 
> On 9/23/20 7:19 PM, john.p.donnelly@xxxxxxxxxx wrote:
>> From: John Donnelly <john.p.donnelly@xxxxxxxxxx>
>> 
>> corrects: drivers/target/target_core_user.c:688:6: warning: 'page' may be used
>> uninitialized
>> 
>> Fixes: 3c58f737231e ("scsi: target: tcmu: Optimize use of
>> flush_dcache_page")
>> 
>> To: linux-scsi@xxxxxxxxxxxxxxx
>> Cc: Mike Christie <michael.christie@xxxxxxxxxx>
>> Signed-off-by: John Donnelly <john.p.donnelly@xxxxxxxxxx>
>> ---
>> drivers/target/target_core_user.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
>> index 9b7592350502..86b28117787e 100644
>> --- a/drivers/target/target_core_user.c
>> +++ b/drivers/target/target_core_user.c
>> @@ -681,7 +681,7 @@ static void scatter_data_area(struct tcmu_dev *udev,
>> 	void *from, *to = NULL;
>> 	size_t copy_bytes, to_offset, offset;
>> 	struct scatterlist *sg;
>> -	struct page *page;
>> +	struct page *page = NULL;
>> 
>> 	for_each_sg(data_sg, sg, data_nents, i) {
>> 		int sg_remaining = sg->length;
>> 
> 
> Looks ok for now. In the next kernel we can do the more invasive approach and
> add a new struct/helpers to make the code cleaner and fix it properly.
> 
> Acked-by: Mike Christie <michael.christie@xxxxxxxxxx>


Hi 

Thank you.

I am not always on the email dlists .. Please do the right thing .