Re: [PATCH v3 03/21] spi: dw: Detach SPI device specific CR0 config method

[Andy Shevchenko]

On Fri, Oct 2, 2020 at 8:47 PM Serge Semin
<Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Oct 02, 2020 at 01:22:46PM +0300, Andy Shevchenko wrote:
> > On Fri, Oct 02, 2020 at 01:28:11AM +0300, Serge Semin wrote:

> > > +   /*
> > > +    * Update CR0 data each time the setup callback is invoked since
> > > +    * the device parameters could have been changed, for instance, by
> > > +    * the MMC SPI driver or something else.
> > > +    */
> > > +   chip->cr0 = dw_spi_get_cr0(dws, spi);
> >
>
> > I would rather name it prepare or alike. 'get' assumes getting value or
> > something like that.
>
> This seems reasonable. What verb do you think would be better: prepare,
> calc, assemble, construct, make, compute, collect, compose, form, compile, etc ?
> Personally prepare or calc or assemble are the best candidates. What do you
> think?

prepare is good enough if you agree on it.


-- 
With Best Regards,
Andy Shevchenko