Re: [PATCHv2 1/9] perf tools: Add build id shell test

[Jiri Olsa]

On Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers wrote:

SNIP

> > > +
> > >  LIBJVMTI = libperf-jvmti.so
> > >
> > >  ifndef NO_JVMTI
> > > @@ -756,6 +763,13 @@ $(OUTPUT)perf-read-vdsox32: perf-read-vdso.c util/find-map.c
> > >         $(QUIET_CC)$(CC) -mx32 $(filter -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c
> > >  endif
> > >
> > > +ifndef NO_BUILDID_EX
> > > +$(OUTPUT)buildid-ex-sha1:
> > > +       $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC) -Wl,--build-id=sha1 -o $@ -x c -
> > > +$(OUTPUT)buildid-ex-md5:
> > > +       $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC) -Wl,--build-id=md5 -o $@ -x c -
> > > +endif
> >
> > Can we just build them in the test shell script instead?

it would solve the build-directory/install-directory
lookup search.. but it'd need to do detect compiler
and depend on it as Ian said

do you have some other reason to compile it in test?

thanks,
jirka

> >
> > Thanks
> > Namhyung
> 
> That'd mean perf test having a dependency on a compiler :-/ That said
> there are some existing dependencies for BPF compilers.

> 
> Thanks,
> Ian

SNIP