Re: [PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address

From: David Miller
Date: Fri Oct 02 2020 - 18:38:53 EST


From: Anant Thazhemadam <anant.thazhemadam@xxxxxxxxx>
Date: Fri, 2 Oct 2020 17:04:13 +0530

> But this patch is about ensuring that an uninitialized variable's
> value (whatever that may be) is not set as the ethernet address
> blindly (without any form of checking if get_registers() worked
> as expected, or not).

Right, and if you are going to check for errors then you have to
handle the error properly.

And the proper way to handle this error is to set a random ethernet
address on the device.