Re: [PATCH v2] mm: Remove src/dst mm parameter in copy_page_range()

[Jason Gunthorpe]

On Fri, Oct 02, 2020 at 03:26:47PM -0400, Peter Xu wrote:
> Both of the mm pointers are not needed after commit 7a4830c380f3 ("mm/fork:
> Pass new vma pointer into copy_page_range()").
> 
> Jason Gunthorpe also reported that the ordering of copy_page_range() is odd.
> Since working at it, reorder the parameters to be logical, by (1) always put
> the dst_* fields to be before src_* fields, and (2) keep the same type of
> parameters together.
> 
> CC: Jason Gunthorpe <jgg@xxxxxxxx>
> CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Reported-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
> Signed-off-by: Peter Xu <peterx@xxxxxxxxxx>
> ---
> v2:
> - further reorder some parameters and line format [Jason]
> ---
>  include/linux/mm.h |   4 +-
>  kernel/fork.c      |   2 +-
>  mm/memory.c        | 139 ++++++++++++++++++++++++---------------------
>  3 files changed, 76 insertions(+), 69 deletions(-)

Thanks, looks more readable to me

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason