Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

[Jiri Pirko]

Thu, Oct 01, 2020 at 03:59:06PM CEST, moshe@xxxxxxxxxxxx wrote:

[...]

> enum devlink_attr {
> 	/* don't change the order or add anything between, this is ABI! */
> 	DEVLINK_ATTR_UNSPEC,
>@@ -507,6 +524,7 @@ enum devlink_attr {
> 
> 	DEVLINK_ATTR_RELOAD_ACTION,		/* u8 */
> 	DEVLINK_ATTR_RELOAD_ACTIONS_PERFORMED,	/* u64 */
>+	DEVLINK_ATTR_RELOAD_LIMIT,	/* u8 */

Hmm, why there could be specified only single "limit"? I believe this
should be a bitfield. Same for the internal api to the driver.

[...]