Re: [PATCH 1/1] efi/libstub/x86: simplify efi_is_native()

[Brian Gerst]

On Sat, Oct 3, 2020 at 2:05 AM Heinrich Schuchardt <xypron.glpk@xxxxxx> wrote:
>
> CONFIG_EFI_MIXED depends on CONFIG_X86_64=y.
> There is no need to check CONFIG_X86_64 again.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx>
> ---
>  arch/x86/include/asm/efi.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
> index b9c2667ac46c..ab28bf1c74cf 100644
> --- a/arch/x86/include/asm/efi.h
> +++ b/arch/x86/include/asm/efi.h
> @@ -223,8 +223,6 @@ static inline bool efi_is_64bit(void)
>
>  static inline bool efi_is_native(void)
>  {
> -       if (!IS_ENABLED(CONFIG_X86_64))
> -               return true;
>         return efi_is_64bit();
>  }

This would then return false for native 32-bit.

--
Brian Gerst