Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values

From: David Miller
Date: Sat Oct 03 2020 - 20:09:19 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Fri, 2 Oct 2020 17:54:22 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently the comparisons of u16 integers value and sopass_val with
> less than zero for error checking is always false because the values
> are unsigned. Fix this by making these variables int. This does not
> affect the shift and mask operations performed on these variables
>
> Addresses-Coverity: ("Unsigned compared against zero")
> Fixes: 49fc23018ec6 ("net: phy: dp83869: support Wake on LAN")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, thank you.