Re: [PATCH net-next 02/16] devlink: Add reload action option to devlink reload command

[Moshe Shemesh]

On 10/2/2020 6:19 PM, Jiri Pirko wrote:
> Thu, Oct 01, 2020 at 03:59:05PM CEST, moshe@xxxxxxxxxxxx wrote:
>
> [...]
>
>
> > diff --git a/include/net/devlink.h b/include/net/devlink.h
> > index 1c286e9a3590..ddba63bce7ad 100644
> > --- a/include/net/devlink.h
> > +++ b/include/net/devlink.h
> > @@ -1077,10 +1077,11 @@ struct devlink_ops {
> > 	 * implemementation.
> > 	 */
> > 	u32 supported_flash_update_params;
> > +	unsigned long reload_actions;
> > 	int (*reload_down)(struct devlink *devlink, bool netns_change,
> > -			   struct netlink_ext_ack *extack);
> > -	int (*reload_up)(struct devlink *devlink,
> > -			 struct netlink_ext_ack *extack);
> > +			   enum devlink_reload_action action, struct netlink_ext_ack *extack);
> > +	int (*reload_up)(struct devlink *devlink, enum devlink_reload_action action,
> > +			 struct netlink_ext_ack *extack, unsigned long *actions_performed);
> Nit. Could you please push extack to be the last arg here? It is common
> to have extack as the last arg + action and actions_performed are going
> to be side by side.


Sure.

> Otherwise the patch looks fine.
> Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>