RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

[Avri Altman]

Please ignore - I was confused with pre-fetch.
Sorry,
Avri

> -----Original Message-----
> From: Avri Altman
> Sent: Sunday, October 4, 2020 10:21 AM
> To: 'Adrian Hunter' <adrian.hunter@xxxxxxxxx>; Martin K . Petersen
> <martin.petersen@xxxxxxxxxx>; James E . J . Bottomley <jejb@xxxxxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Alim Akhtar
> <alim.akhtar@xxxxxxxxxxx>
> Subject: RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature
> 
> > +       /*
> > +        * DeepSleep requires the Immediate flag. DeepSleep state is actually
> > +        * entered when the link state goes to Hibern8.
> > +        */
> > +       if (pwr_mode == UFS_DEEPSLEEP_PWR_MODE)
> > +               cmd[1] = 1;
> Shouldn't it be bit1, i.e. cmd[1] = 2 ?
> 
> >         cmd[4] = pwr_mode << 4;
> >