Re: [RFC PATCH v3 2/4] objtool: x86 instruction decoder and big endian cross compiles

[Masami Hiramatsu]

On Fri, 2 Oct 2020 10:18:41 -0500
Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> On Thu, Oct 01, 2020 at 12:17:25AM +0200, Vasily Gorbik wrote:
> > From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> > 
> > Currently objtool seems to be the only tool from build tools needed
> > which breaks x86 cross compilation on big endian systems. Make the x86
> > instruction decoder of the objtool usable on big endian machines.
> > 
> > Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> > Co-developed-by: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> > Signed-off-by: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> 
> Since this changes the decoder (which is shared with the kernel), please
> prefix the subject with "x86/insn:" instead of "objtool".

Thanks for pointing it.

> 
> This patch is a bit ugly, but I don't necessarily have a better idea.
> 
> Masami?

Yeah, agreed. Maybe we can split that part in different header, but
that makes it more ugly. And code itself looks good to me.
(I like insn_field_set() idea :) )

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thank you!


> -- 
> Josh
> 


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>