Re: [PATCH] crypto: jitterentropy - bind statically into kernel

From: Stephan Mueller
Date: Mon Oct 05 2020 - 03:45:42 EST


Am Montag, 5. Oktober 2020, 08:44:39 CEST schrieb Ard Biesheuvel:

Hi Ard,

> On Mon, 5 Oct 2020 at 08:40, Stephan Mueller <smueller@xxxxxxxxxx> wrote:
> > Am Montag, 5. Oktober 2020, 08:24:46 CEST schrieb Ard Biesheuvel:
> >
> > Hi Ard,
> >
> > > If jitterentropy is a special case, we could put a alternate
> > > non-'static inline' version of random_get_entropy() in the core
> > > kernel, and only export it if JITTER_ENTROPY is built as a module in
> > > the first place. But I'd prefer it if jitterentropy switches to an API
> > > that is suitable for driver consumption.
> >
> > Which API do you have in mind? In user space, I use
> > clock_gettime(CLOCK_REALTIME) which also considers the clock source.
>
> AFAICT, that call is backed by ktime_get_real_ts64(), which is already
> being exported to modules.
>
> Could you please check whether that works for your driver?

Yes, will do. Thanks.

Ciao
Stephan