Re: [PATCH v39 11/24] x86/sgx: Add SGX enclave driver

From: Christoph Hellwig
Date: Mon Oct 05 2020 - 04:46:03 EST


On Sat, Oct 03, 2020 at 04:39:25PM +0200, Greg KH wrote:
> > @@ -0,0 +1,173 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
>
> You use gpl-only header files in this file, so how in the world can it
> be bsd-3 licensed?
>
> Please get your legal department to agree with this, after you explain
> to them how you are mixing gpl2-only code in with this file.
>
> > +// Copyright(c) 2016-18 Intel Corporation.
>
> Dates are hard to get right :(

As is comment formatting apparently. Don't use // comments for anything
but the SPDX header, please.