Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions

[Rob Herring]

On Sun, Oct 4, 2020 at 12:50 AM Phil Chang <phil.chang@xxxxxxxxxxxx> wrote:
>
> Certain SoCs need to support large amount of reserved memory
> regions, especially to follow the GKI rules from Google.
> In MTK new SoC requires more than 68 regions of reserved memory
> for each IP's usage, such as load firmware to specific sapce,

typo

> so that need to reserve more regisions

typo. Missing punctuation.

>
> Signed-off-by: Joe Liu <joe.liu@xxxxxxxxxxxx>
> Signed-off-by: YJ Chiang <yj.chiang@xxxxxxxxxxxx>
> Signed-off-by: Alix Wu <alix.wu@xxxxxxxxxxxx>
> Signed-off-by: Phil Chang <phil.chang@xxxxxxxxxxxx>
> ---
>  drivers/of/of_reserved_mem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 46b9371c8a33..595f0741dcef 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -22,7 +22,7 @@
>  #include <linux/slab.h>
>  #include <linux/memblock.h>
>
> -#define MAX_RESERVED_REGIONS   64
> +#define MAX_RESERVED_REGIONS   128

At some point, this starts to feel like abuse of reserved regions.
Please provide details on what the regions are.

Also, this probably just needs to be dynamic. I think we're at that point.

Rob