Re: [PATCH v6 2/7] dt-bindings: leds: Convert pwm to yaml
From: Rob Herring
Date: Mon Oct 05 2020 - 09:51:37 EST
On Thu, 01 Oct 2020 01:46:32 +0200, Alexander Dahl wrote:
> The example was adapted in the following ways:
>
> - make use of the now supported 'function' and 'color' properties
> - remove pwm nodes, those are documented elsewhere
> - tweake node names to be matched by new dtschema rules
>
> License was discussed with the original author.
>
> Suggested-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
> Signed-off-by: Alexander Dahl <post@xxxxxxxxxxx>
> Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> ---
>
> Notes:
> v5 -> v6:
> * removed pwm nodes from example (Rob)
> * renamed led-controller node in example (Rob)
>
> v4 -> v5:
> * updated based on feedback by Rob Herring
> * removed Acked-by
>
> v3 -> v4:
> * added Cc to original author of the binding
>
> v2 -> v3:
> * changed license identifier to recommended one
> * added Acked-by
>
> v2:
> * added this patch to series (Suggested-by: Jacek Anaszewski)
>
> .../devicetree/bindings/leds/leds-pwm.txt | 50 -------------
> .../devicetree/bindings/leds/leds-pwm.yaml | 70 +++++++++++++++++++
> 2 files changed, 70 insertions(+), 50 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
> create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-pwm.yaml
See https://patchwork.ozlabs.org/patch/1374765
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.