Re: [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe"

From: Doug Anderson
Date: Mon Oct 05 2020 - 10:43:38 EST


Hi,

On Mon, Oct 5, 2020 at 2:03 AM Vignesh Raghavendra <vigneshr@xxxxxx> wrote:
>
> This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.
>
> This leads to warn dump like [1] on some platforms and reorders MTD
> devices thus may break user space expectations. So revert the change.
>
> [1]:
>
> [ 1.849801] ------------[ cut here ]------------
> [ 1.854271] mscc_felix 0000:00:00.5: device is disabled, skipping
> [ 1.858753] WARNING: CPU: 1 PID: 7 at kernel/kmod.c:136 __request_module+0x3a4/0x568
>
> [...]
>
> Reported-by: Michael Walle <michael@xxxxxxxx>
> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
> ---
> drivers/mtd/spi-nor/core.c | 1 -
> 1 file changed, 1 deletion(-)

Thank you for the revert and sorry for the breakage.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>