Re: [PATCH] leds: lm3697: Fix out-of-bound access

[ultracoolguy]

 Well, the major benefit I see is that it makes the driver slightly more readable. However I'm fine with whatever you guys decide.

I'll attach the patch with the struct renaming removed just in case.



Oct 5, 2020, 14:41 by dmurphy@xxxxxx:

> Gabriel
>
> On 10/5/20 9:38 AM, ultracoolguy@xxxxxxxxxxxx wrote:
>
>> I understand. So I should leave it like it was and do the rename in another patch?
>>
>
> You should do the fix in one patch and leave the structure name alone.
>
> The structure naming if fine and has no benefit and actually will make it more difficult for others to backport future fixes.
>
> Unless Pavel finds benefit in accepting the structure rename.
>
> Dan
>