Re: [EXTERNAL] Re: [PATCH v5 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

From: Ricardo Rivera-Matos
Date: Mon Oct 05 2020 - 13:33:19 EST


Sebastian,

On 10/3/20 5:54 AM, Sebastian Reichel wrote:
Hi Ricardo,

On Thu, Oct 01, 2020 at 04:40:34PM -0500, Ricardo Rivera-Matos wrote:
The BQ256XX family of devices are highly integrated buck chargers
for single cell batteries.

Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@xxxxxx>

v5 - adds power_supply_put_battery_info() and devm_add_action_or_reset() calls
---
changes look good, but you are still missing
usb_unregister_notifier() calls on drival removal.
ACK, I will add a driver removal function and make the appropriate usb_unregister_notifier() calls.

-- Sebastian
Ricardo