Re: [PATCH v2 2/2] arm: sti LL_UART: add STiH418 SBC UART0 support

[Patrice CHOTARD]

Hi Alain

On 8/30/20 9:57 PM, Alain Volmat wrote:
> Add the entry for the STiH418 SBC UART0 low level uart.
>
> Signed-off-by: Alain Volmat <avolmat@xxxxxx>
> ---
>  arch/arm/Kconfig.debug | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index e97d6e5c8898..447d177fcf8d 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -1204,6 +1204,16 @@ choice
>  
>  		  If unsure, say N.
>  
> +	config DEBUG_STIH418_SBC_ASC0
> +		bool "Use StiH418 SBC ASC0 UART for low-level debug"
> +		depends on ARCH_STI
> +		help
> +		  Say Y here if you want kernel low-level debugging support
> +		  on STiH418 based platforms which has default UART wired
> +		  up to SBC ASC0.
> +
> +		  If unsure, say N.
> +
>  	config STM32F4_DEBUG_UART
>  		bool "Use STM32F4 UART for low-level debug"
>  		depends on MACH_STM32F429 || MACH_STM32F469
> @@ -1587,6 +1597,7 @@ config DEBUG_LL_INCLUDE
>  	default "debug/sirf.S" if DEBUG_SIRFSOC_UART
>  	default "debug/sti.S" if DEBUG_STIH41X_ASC2
>  	default "debug/sti.S" if DEBUG_STIH41X_SBC_ASC1
> +	default "debug/sti.S" if DEBUG_STIH418_SBC_ASC0
>  	default "debug/stm32.S" if DEBUG_STM32_UART
>  	default "debug/tegra.S" if DEBUG_TEGRA_UART
>  	default "debug/ux500.S" if DEBUG_UX500_UART
> @@ -1620,6 +1631,7 @@ config DEBUG_UART_PHYS
>  	default 0x03010fe0 if ARCH_RPC
>  	default 0x07000000 if DEBUG_SUN9I_UART0
>  	default 0x09405000 if DEBUG_ZTE_ZX
> +	default 0x09530000 if DEBUG_STIH418_SBC_ASC0
>  	default 0x10009000 if DEBUG_REALVIEW_STD_PORT || \
>  				DEBUG_VEXPRESS_UART0_CA9
>  	default 0x1010c000 if DEBUG_REALVIEW_PB1176_PORT
> @@ -1750,7 +1762,8 @@ config DEBUG_UART_PHYS
>  		DEBUG_BCM63XX_UART || DEBUG_ASM9260_UART || \
>  		DEBUG_SIRFSOC_UART || DEBUG_DIGICOLOR_UA0 || \
>  		DEBUG_AT91_UART || DEBUG_STM32_UART || \
> -		DEBUG_STIH41X_ASC2 || DEBUG_STIH41X_SBC_ASC1
> +		DEBUG_STIH41X_ASC2 || DEBUG_STIH41X_SBC_ASC1 || \
> +		DEBUG_STIH418_SBC_ASC0
>  
>  config DEBUG_UART_VIRT
>  	hex "Virtual base address of debug UART"
> @@ -1796,6 +1809,7 @@ config DEBUG_UART_VIRT
>  	default 0xf8090000 if DEBUG_VEXPRESS_UART0_RS1
>  	default 0xf8ffee00 if DEBUG_AT91_SAM9263_DBGU
>  	default 0xf8fff200 if DEBUG_AT91_RM9200_DBGU
> +	default 0xf9530000 if DEBUG_STIH418_SBC_ASC0
>  	default 0xf9e09000 if DEBUG_AM33XXUART1
>  	default 0xfa020000 if DEBUG_OMAP4UART3 || DEBUG_TI81XXUART1
>  	default 0xfa022000 if DEBUG_TI81XXUART2
> @@ -1864,7 +1878,8 @@ config DEBUG_UART_VIRT
>  		DEBUG_BCM63XX_UART || DEBUG_ASM9260_UART || \
>  		DEBUG_SIRFSOC_UART || DEBUG_DIGICOLOR_UA0 || \
>  		DEBUG_AT91_UART || DEBUG_STM32_UART || \
> -		DEBUG_STIH41X_ASC2 || DEBUG_STIH41X_SBC_ASC1
> +  		DEBUG_STIH41X_ASC2 || DEBUG_STIH41X_SBC_ASC1 || \
> +		DEBUG_STIH418_SBC_ASC0
>  
>  config DEBUG_UART_8250_SHIFT
>  	int "Register offset shift for the 8250 debug UART"

Reviewed-by: Patrice Chotard <patrice.chotard@xxxxxx>

Thanks

Patrice