Re: [BUG][PATCH] arm64: bti: fix BTI to handle local indirect branches

[kernel test robot]

Hi Jeremy,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on soc/for-next arm/for-next kvmarm/next v5.9-rc8 next-20201002]
[cannot apply to xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jeremy-Linton/arm64-bti-fix-BTI-to-handle-local-indirect-branches/20201006-021958
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/37211f8bd05c9ebcede89bb5c371e34920355d4f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jeremy-Linton/arm64-bti-fix-BTI-to-handle-local-indirect-branches/20201006-021958
        git checkout 37211f8bd05c9ebcede89bb5c371e34920355d4f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> arch/arm64/crypto/aes-neonbs-core.S:491:23: error: macro "SYM_END" requires 2 arguments, but only 1 given
     491 | SYM_END(aesbs_encrypt8)
         |                       ^
   In file included from arch/arm64/crypto/aes-neonbs-core.S:17:
   include/linux/linkage.h:166: note: macro "SYM_END" defined here
     166 | #define SYM_END(name, sym_type)    \
         | 
   arch/arm64/crypto/aes-neonbs-core.S:556:23: error: macro "SYM_END" requires 2 arguments, but only 1 given
     556 | SYM_END(aesbs_decrypt8)
         |                       ^
   In file included from arch/arm64/crypto/aes-neonbs-core.S:17:
   include/linux/linkage.h:166: note: macro "SYM_END" defined here
     166 | #define SYM_END(name, sym_type)    \
         | 

vim +/SYM_END +491 arch/arm64/crypto/aes-neonbs-core.S

   429	
   430		.align		4
   431	SYM_CODE_START_LOCAL(aesbs_encrypt8)
   432		ldr		q9, [bskey], #16		// round 0 key
   433		ldr		q8, M0SR
   434		ldr		q24, SR
   435	
   436		eor		v10.16b, v0.16b, v9.16b		// xor with round0 key
   437		eor		v11.16b, v1.16b, v9.16b
   438		tbl		v0.16b, {v10.16b}, v8.16b
   439		eor		v12.16b, v2.16b, v9.16b
   440		tbl		v1.16b, {v11.16b}, v8.16b
   441		eor		v13.16b, v3.16b, v9.16b
   442		tbl		v2.16b, {v12.16b}, v8.16b
   443		eor		v14.16b, v4.16b, v9.16b
   444		tbl		v3.16b, {v13.16b}, v8.16b
   445		eor		v15.16b, v5.16b, v9.16b
   446		tbl		v4.16b, {v14.16b}, v8.16b
   447		eor		v10.16b, v6.16b, v9.16b
   448		tbl		v5.16b, {v15.16b}, v8.16b
   449		eor		v11.16b, v7.16b, v9.16b
   450		tbl		v6.16b, {v10.16b}, v8.16b
   451		tbl		v7.16b, {v11.16b}, v8.16b
   452	
   453		bitslice	v0, v1, v2, v3, v4, v5, v6, v7, v8, v9, v10, v11
   454	
   455		sub		rounds, rounds, #1
   456		b		.Lenc_sbox
   457	
   458	.Lenc_loop:
   459		shift_rows	v0, v1, v2, v3, v4, v5, v6, v7, v24
   460	.Lenc_sbox:
   461		sbox		v0, v1, v2, v3, v4, v5, v6, v7, v8, v9, v10, v11, v12, \
   462									v13, v14, v15
   463		subs		rounds, rounds, #1
   464		b.cc		.Lenc_done
   465	
   466		enc_next_rk
   467	
   468		mix_cols	v0, v1, v4, v6, v3, v7, v2, v5, v8, v9, v10, v11, v12, \
   469									v13, v14, v15
   470	
   471		add_round_key	v0, v1, v2, v3, v4, v5, v6, v7
   472	
   473		b.ne		.Lenc_loop
   474		ldr		q24, SRM0
   475		b		.Lenc_loop
   476	
   477	.Lenc_done:
   478		ldr		q12, [bskey]			// last round key
   479	
   480		bitslice	v0, v1, v4, v6, v3, v7, v2, v5, v8, v9, v10, v11
   481	
   482		eor		v0.16b, v0.16b, v12.16b
   483		eor		v1.16b, v1.16b, v12.16b
   484		eor		v4.16b, v4.16b, v12.16b
   485		eor		v6.16b, v6.16b, v12.16b
   486		eor		v3.16b, v3.16b, v12.16b
   487		eor		v7.16b, v7.16b, v12.16b
   488		eor		v2.16b, v2.16b, v12.16b
   489		eor		v5.16b, v5.16b, v12.16b
   490		ret
 > 491	SYM_END(aesbs_encrypt8)
   492	
   493		.align		4
   494	SYM_CODE_START_LOCAL(aesbs_decrypt8)
   495		lsl		x9, rounds, #7
   496		add		bskey, bskey, x9
   497	
   498		ldr		q9, [bskey, #-112]!		// round 0 key
   499		ldr		q8, M0ISR
   500		ldr		q24, ISR
   501	
   502		eor		v10.16b, v0.16b, v9.16b		// xor with round0 key
   503		eor		v11.16b, v1.16b, v9.16b
   504		tbl		v0.16b, {v10.16b}, v8.16b
   505		eor		v12.16b, v2.16b, v9.16b
   506		tbl		v1.16b, {v11.16b}, v8.16b
   507		eor		v13.16b, v3.16b, v9.16b
   508		tbl		v2.16b, {v12.16b}, v8.16b
   509		eor		v14.16b, v4.16b, v9.16b
   510		tbl		v3.16b, {v13.16b}, v8.16b
   511		eor		v15.16b, v5.16b, v9.16b
   512		tbl		v4.16b, {v14.16b}, v8.16b
   513		eor		v10.16b, v6.16b, v9.16b
   514		tbl		v5.16b, {v15.16b}, v8.16b
   515		eor		v11.16b, v7.16b, v9.16b
   516		tbl		v6.16b, {v10.16b}, v8.16b
   517		tbl		v7.16b, {v11.16b}, v8.16b
   518	
   519		bitslice	v0, v1, v2, v3, v4, v5, v6, v7, v8, v9, v10, v11
   520	
   521		sub		rounds, rounds, #1
   522		b		.Ldec_sbox
   523	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip