Re: [PATCH] leds: lm3697: Fix out-of-bound access
From: Marek Behun
Date: Tue Oct 06 2020 - 03:34:03 EST
By the way I just realized that the DT binding in this driver seems
incorrect to me.
The controller logically supports 3 LED strings, each having
configurable control bank.
But the DT binding supports 2 DT nodes, one for each control bank
(identified by the `reg` property) and then `led-sources` says which
string should be controlled by given bank.
But taking in mind that DT should describe how devices are connected to
each other, I think the child nodes in the binding should instead
describe the 3 supported LED strings...
Marek