Re: [PATCH 2/2] x86/entry/32: Remove leftover macros after stackprotector cleanups
From: Peter Zijlstra
Date: Tue Oct 06 2020 - 04:35:22 EST
On Mon, Oct 05, 2020 at 12:30:04PM -0700, Andy Lutomirski wrote:
> .macro SAVE_ALL pt_regs_ax=%eax switch_stacks=0 skip_gs=0 unwind_espfix=0
> cld
> .if \skip_gs == 0
> - PUSH_GS
> + pushl $0
> .endif
> pushl %fs
>
Is there a good reason not to just push gs into it? It might be nice if
pt_regs is complete.