Re: [PATCH] media: ov8856: decrease hs_trail time

[Sakari Ailus]

Hi David,

On Mon, Jul 27, 2020 at 11:07:48AM +0800, David Lu wrote:
> To meet mipi hi speed transmission, decrease hs_trail time to pass mipi
> test.
> 
> Signed-off-by: David Lu <david.lu@xxxxxxxxxxxxxx>
> ---
>  drivers/media/i2c/ov8856.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c
> index 4ca27675cc5a..1f1835b14a24 100644
> --- a/drivers/media/i2c/ov8856.c
> +++ b/drivers/media/i2c/ov8856.c
> @@ -284,7 +284,7 @@ static const struct ov8856_reg mode_3280x2464_regs[] = {
>  	{0x4601, 0x80},
>  	{0x4800, 0x44},
>  	{0x4816, 0x53},
> -	{0x481b, 0x58},
> +	{0x481b, 0x42},

Could you elaborate a little more in the commit message what does the
register do and exactly what is changed? Is it the raw ths_trail value or
something else?

The nature of the change is such that it is very likely board specific
somehow. If you change this value for your system, does the change have
adverse effects elsewhere?

>  	{0x481f, 0x27},
>  	{0x4837, 0x16},
>  	{0x483c, 0x0f},
> @@ -474,7 +474,7 @@ static const struct ov8856_reg mode_1640x1232_regs[] = {
>  	{0x4601, 0x80},
>  	{0x4800, 0x44},
>  	{0x4816, 0x53},
> -	{0x481b, 0x58},
> +	{0x481b, 0x42},
>  	{0x481f, 0x27},
>  	{0x4837, 0x16},
>  	{0x483c, 0x0f},

-- 
Kind regards,

Sakari Ailus