Re: [PATCH 0/2] Enable GPIO and I2C configs for TI's J721e platform

[Faiz Abbas]

Hi Tero,

On 06/10/20 5:21 pm, Tero Kristo wrote:
> On 02/10/2020 19:45, Faiz Abbas wrote:
>> The following patches enable configs in the arm64 defconfig to support
>> GPIO and I2C support on TI's J721e platform.
>>
>> Faiz Abbas (2):
>>    arm64: defconfig: Enable OMAP I2C driver
>>    arm64: defconfig: Enable DAVINCI_GPIO driver
>>
>>   arch/arm64/configs/defconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
> 
> Why are you enabling these?
> 
> Are they required for booting the board?
> 
> If not, they shall not be enabled, as it just clutters the arm64 defconfig unnecessarily.
> 

They are required because the SD card regulators need gpio over i2c expander and also
soc gpio support to come up in UHS modes.

But in general isn't any feature we add supposed to be enabled in the arm64 defconfig?

Thanks,
Faiz