Re: [PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc

From: Peter Zijlstra
Date: Tue Oct 06 2020 - 09:17:52 EST


On Tue, Oct 06, 2020 at 01:41:47PM +0100, Will Deacon wrote:
> On Thu, Sep 24, 2020 at 05:48:51PM +0200, Sebastian Andrzej Siewior wrote:
> > ctags creates a warning:
> > |ctags: Warning: include/linux/seqlock.h:738: null expansion of name pattern "\2"
> >
> > The DEFINE_SEQLOCK() macro is passed to ctags and being told to expect
> > an argument.
> >
> > Add a dummy argument to keep ctags quiet.
> >
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> > ---
> > include/linux/seqlock.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
> > index 962d9768945f0..4a69e74dc7ce9 100644
> > --- a/include/linux/seqlock.h
> > +++ b/include/linux/seqlock.h
> > @@ -735,7 +735,7 @@ typedef struct {
> > } while (0)
> >
> > /**
> > - * DEFINE_SEQLOCK() - Define a statically allocated seqlock_t
> > + * DEFINE_SEQLOCK(sl) - Define a statically allocated seqlock_t
> > * @sl: Name of the seqlock_t instance
> > */
> > #define DEFINE_SEQLOCK(sl) \
>
> Acked-by: Will Deacon <will@xxxxxxxxxx>


Thanks!