Re: [net v2] net: dsa: microchip: fix race condition

From: Vladimir Oltean
Date: Tue Oct 06 2020 - 12:57:45 EST


On Tue, Oct 06, 2020 at 06:30:57PM +0200, Christian Eggers wrote:
> If think that ksz_switch_remove() will not be called at all if there is an
> error in the probe path.

Indeed.

> In all other cases, the work should be queued.

In that case, it looks like the "if" condition can be removed in a
further patch, because it is now unnecessary. Please be sure to test
that though.