Re: [PATCH] net/mlx5e: Fix freeing of unassigned pointer

[Saeed Mahameed]

On Sat, 2020-10-03 at 12:10 +0100, Alex Dewar wrote:
> Commit ff7ea04ad579 ("net/mlx5e: Fix potential null pointer
> dereference")
> added some missing null checks but the error handling in
> mlx5e_alloc_flow() was left broken: the variable attr is passed to
> kfree
> although it is never assigned to and never needs to be freed in this
> function. Fix this.
> 
> Addresses-Coverity-ID: 1497536 ("Memory - illegal accesses")
> Fixes: ff7ea04ad579 ("net/mlx5e: Fix potential null pointer
> dereference")
> Signed-off-by: Alex Dewar <alex.dewar90@xxxxxxxxx>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 17 +++++++++----
> ----
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 

Hi Alex, thanks for the patch, 
Colin submitted a one liner patch that I already picked up.

I hope you are ok with this.

Thanks,
Saeed.