Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

From: Chun-Kuang Hu
Date: Tue Oct 06 2020 - 20:02:32 EST


Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> 於 2020年10月7日 週三 上午3:33寫道:
>
> From: CK Hu <ck.hu@xxxxxxxxxxxx>
>
> Actually, setting the registers for routing, use multiple 'if-else' for different
> routes, but this code would be more and more complicated while we
> support more and more SoCs. Change that and use a table per SoC so the
> code will be more portable and clear.

Reviewed-by: Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>

>
> Signed-off-by: CK Hu <ck.hu@xxxxxxxxxxxx>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> ---
>
> drivers/soc/mediatek/mtk-mmsys.c | 393 +++++++++++++++++--------------
> 1 file changed, 210 insertions(+), 183 deletions(-)
>