Re: [PATCH v3 7/7] ARM: dts: imx50-kobo-aura: Add Netronix embedded controller

[Krzysztof Kozlowski]

On Fri, 25 Sep 2020 at 07:10, Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> wrote:
>
> Enable the Netronix EC on the Kobo Aura ebook reader.
>
> Several features are still missing:
>  - Frontlight/backlight. The vendor kernel drives the frontlight LED
>    using the PWM output of the EC and an additional boost pin that
>    increases the brightness.
>  - Battery monitoring
>  - Interrupts for RTC alarm and low-battery events
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
> ---
>
> v3:
> - Remove interrupt-controller property from embedded-controller node
> - subnodes of embedded-controller node in to the main node
>
> v2:
> - https://lore.kernel.org/lkml/20200905144503.1067124-3-j.neuschaefer@xxxxxxx/
> - Fix pwm-cells property (should be 2, not 1)
> ---
>  arch/arm/boot/dts/imx50-kobo-aura.dts | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx50-kobo-aura.dts b/arch/arm/boot/dts/imx50-kobo-aura.dts
> index a0eaf869b9135..2d1a59091a37c 100644
> --- a/arch/arm/boot/dts/imx50-kobo-aura.dts
> +++ b/arch/arm/boot/dts/imx50-kobo-aura.dts
> @@ -6,6 +6,7 @@
>  /dts-v1/;
>  #include "imx50.dtsi"
>  #include <dt-bindings/input/input.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
>
>  / {
>         model = "Kobo Aura (N514)";
> @@ -135,10 +136,24 @@ &i2c3 {
>         pinctrl-0 = <&pinctrl_i2c3>;
>         status = "okay";
>
> -       /* TODO: embedded controller at 0x43 */
> +       embedded-controller@43 {
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_ec>;
> +               compatible = "netronix,ntxec";
> +               reg = <0x43>;
> +               system-power-controller;
> +               interrupts-extended = <&gpio4 11 IRQ_TYPE_EDGE_FALLING>;
> +               #pwm-cells = <2>;
> +       };
>  };
>
>  &iomuxc {
> +       pinctrl_ec: ec {

This should fail on dtschema check - pinctrl groups should end with "grp".

Best regards,
Krzysztof