Re: [PATCH -next] mm: Use sysfs_emit functions not sprintf

[Jason Gunthorpe]

On Wed, Oct 07, 2020 at 12:16:01AM -0700, Kees Cook wrote:
> On Tue, Oct 06, 2020 at 09:28:17AM -0700, Joe Perches wrote:
> > Convert the various uses of sprintf/snprintf/scnprintf to
> > format sysfs output to sysfs_emit and sysfs_emit_at to make
> > clear the output is sysfs related and to avoid any possible
> > buffer overrun of the PAGE_SIZE buffer.
> > 
> > Done with cocci scripts and some typing.
> 
> Can you include the cocci script in the commit log? It might be nicer to
> split the "manual" changes from the cocci changes, as that makes review
> much easier too.
> 
> Regardless, yes, I'm a fan of switching these all around to
> sysfs_emit*(). :)

Yah, +1, I'd welcome patches for drivers/infiniband as well next cycle

Thanks,
Jason