Re: Build regressions/improvements in v5.9-rc8

[Richard Weinberger]

On Wed, Oct 7, 2020 at 2:47 PM Paul Bolle <pebolle@xxxxxxxxxx> wrote:
>
> Richard Weinberger schreef op wo 07-10-2020 om 14:08 [+0200]:
> > UML has no ia32 emulation and therefore no in_ia32_syscall().
> > Maybe you can check for CONFIG_IA32_EMULATION too?
>
> The pending fix is:
>     #if defined(CONFIG_X86_64) && !defined(CONFIG_UML)
>
> Since this check guards in_ia32_syscall() just checking CONFIG_IA32_EMULATION
> should do too.
>
> (Way outside my limited expertise, but anyway: is does look odd to see a call
> to in_ia32_syscall() in drivers/. All other calls are in arch/x86/. Isn't this
> a bit too x86 specific for an arch independent driver?)

Indeed. in_compat_syscall() seems to be more suitable.

But for UML this does not really help, I fear, it has also no CONFIG_COMPAT.

-- 
Thanks,
//richard