Re: [PATCH] PM: runtime: Use pmruntime sync variant to put suppliers

[Rafael J. Wysocki]

On Wed, Oct 7, 2020 at 2:20 AM Stanimir Varbanov
<stanimir.varbanov@xxxxxxxxxx> wrote:
>
> Calling pm_runtime_put_sync over a device with suppliers with device
> link flags PM_RUNTIME | RPM_ACTIVE it is observed that the supplier
> is not put (turned off) at the end, but instead put asynchronously.

Yes, that's by design.

> In some case This could lead to issues for the callers which expects
> that the pmruntime sync variants should also put the suppliers
> synchronously.

Why would anyone expect that to happen?

> Also the opposite rpm_get_suppliers is already using pmruntime _sync
> variant of the API.

Yes, it does, because that is necessary.

> Correct this by changing pmruntime_put to pmruntime_put_sync in
> rpm_put_suppliers.

It is not a correction, but a change in behavior without good enough
rationale, as it stands.

Thanks!