Re: linux-next: build failure after merge of the vfs tree
From: Josh Poimboeuf
Date: Wed Oct 07 2020 - 11:47:10 EST
On Wed, Oct 07, 2020 at 08:04:05AM +1100, Stephen Rothwell wrote:
> Hi Josh,
>
> On Tue, 6 Oct 2020 09:30:12 -0500 Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> >
> > On Mon, Sep 28, 2020 at 11:10:56PM -0500, Josh Poimboeuf wrote:
> > > > Josh, any ideas? We could, of course, make it "r"(size), but that would
> > > > be unpleasant in all existing callers...
> > >
> > > Sorry, I've been traveling. I'd just vote for making it "r".
> > >
> > > array_index_nospec() is always called after a usercopy. I don't think
> > > anyone will notice the extra mov, for the cases where it would be
> > > propagated as an immediate. And the argument *is* an unsigned long
> > > after all.
> > >
> > > Stephen, can you confirm this fixes it?
> >
> > Still traveling, I didn't see an update on this. Any objections to the
> > below? I assume it fixes Stephen's build issue.
>
> Yes, it does fix my x86_64 allnoconfig build.
Stephen, thanks!
Al, do you want to fold that change in? Or shall I post another
version?
--
Josh