Re: [PATCH] qla2xxx: Do not consume srb greedily

[Arun Easi]

On Tue, 29 Sep 2020, 12:38am, Daniel Wagner wrote:

> qla2xx_process_get_sp_from_handle() will clear the slot which the
> current srb is stored. So this function has a side effect. Therefore,
> we can't use it in qla24xx_process_mbx_iocb_response() to check
> for consistency and later again in qla24xx_mbx_iocb_entry().
> 
> Let's move the consistency check directly into
> qla24xx_mbx_iocb_entry() and avoid the double call or any open coding
> of the qla2xx_process_get_sp_from_handle() functionality.
> 
> Fixes: 31a3271ff11b ("scsi: qla2xxx: Handle incorrect entry_type entries")
> Signed-off-by: Daniel Wagner <dwagner@xxxxxxx>

That was a nasty one, good that you caught it soon.

Reviewed-by: Arun Easi <aeasi@xxxxxxxxxxx>

Regards,
-Arun