Re: [PATCH 0/3] Venus dynamic resolution change fixes

[vgarodia]

Hi Stan,

On 2020-09-28 22:14, Stanimir Varbanov wrote:
> Hi all,
>
> Those three patches are needed to fix setting of LAST buffer flag 
> during
> dynamic-resolution-change state.
>
> The first patch in this series fix the LAST buffer flag setting, the 
> second
> unify the driver behavior no matter the event from firmware is 
> sufficient or
> insufficient resources and the third one is moving the locking from 
> buf_queue
> helper function to encoder and decoder buf_queue vb2 ops.
>
> Comments are welcome!
>
> Stanimir Varbanov (3):
>   venus: vdec: Fix non reliable setting of LAST flag
>   venus: vdec: Make decoder return LAST flag for sufficient event
>   venus: helpers: Lock outside of buffer queue helper
>
>  drivers/media/platform/qcom/venus/core.h    |  5 +-
>  drivers/media/platform/qcom/venus/helpers.c | 15 ++--
>  drivers/media/platform/qcom/venus/vdec.c    | 92 +++++++++++++--------
>  drivers/media/platform/qcom/venus/venc.c    | 11 ++-
>  4 files changed, 76 insertions(+), 47 deletions(-)

I have made some comments which are more towards optimizing the reconfig 
event
handling in the driver. I would leave that up to you to either update in 
this series
or take it separately. Either way, i am good with this series.

Reviewed-by: Vikash Garodia <vgarodia@xxxxxxxxxxxxxx>