Re: [PATCH v4 5/7] tracing: Add README information for synthetic_events file

[Masami Hiramatsu]

Hi Tom,

On Sun,  4 Oct 2020 17:14:07 -0500
Tom Zanussi <zanussi@xxxxxxxxxx> wrote:

> Add an entry with a basic description of events/synthetic_events along
> with a simple example.
> 
> Signed-off-by: Tom Zanussi <zanussi@xxxxxxxxxx>

This looks good to me.

Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thank you,

> ---
>  kernel/trace/trace.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 3f2533adae72..73fd0e0c0f39 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -5249,7 +5249,12 @@ static const char readme_msg[] =
>  	"\t        trace(<synthetic_event>,param list)  - generate synthetic event\n"
>  	"\t        save(field,...)                      - save current event fields\n"
>  #ifdef CONFIG_TRACER_SNAPSHOT
> -	"\t        snapshot()                           - snapshot the trace buffer\n"
> +	"\t        snapshot()                           - snapshot the trace buffer\n\n"
> +#endif
> +#ifdef CONFIG_SYNTH_EVENTS
> +	"  events/synthetic_events\t- Create/append/remove/show synthetic events\n"
> +	"\t  Write into this file to define/undefine new synthetic events.\n"
> +	"\t     example: echo 'myevent u64 lat; char name[]' >> synthetic_events\n"
>  #endif
>  #endif
>  ;
> -- 
> 2.17.1
> 


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>