Re: [PATCH v3 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap

[John Stultz]

On Wed, Oct 7, 2020 at 12:44 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> Hi John,
>
> url:    https://github.com/0day-ci/linux/commits/John-Stultz/dma-buf-Performance-improvements-for-system-heap-a-system-uncached-implementation/20201003-120520
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c
> config: i386-randconfig-m021-20201002 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> smatch warnings:
> drivers/dma-buf/heaps/system_heap.c:496 system_heap_create() warn: passing zero to 'PTR_ERR'
>
> vim +/PTR_ERR +496 drivers/dma-buf/heaps/system_heap.c
>
> efa04fefebbd724 John Stultz     2019-12-03  478  static int system_heap_create(void)
> efa04fefebbd724 John Stultz     2019-12-03  479  {
> efa04fefebbd724 John Stultz     2019-12-03  480         struct dma_heap_export_info exp_info;
> efa04fefebbd724 John Stultz     2019-12-03  481
> 263e38f82cbb35b Andrew F. Davis 2019-12-16  482         exp_info.name = "system";
> efa04fefebbd724 John Stultz     2019-12-03  483         exp_info.ops = &system_heap_ops;
> efa04fefebbd724 John Stultz     2019-12-03  484         exp_info.priv = NULL;
> efa04fefebbd724 John Stultz     2019-12-03  485
> efa04fefebbd724 John Stultz     2019-12-03  486         sys_heap = dma_heap_add(&exp_info);
> efa04fefebbd724 John Stultz     2019-12-03  487         if (IS_ERR(sys_heap))
> a2e10cdd2e4d12a John Stultz     2020-10-03  488                 return PTR_ERR(sys_heap);
> efa04fefebbd724 John Stultz     2019-12-03  489
> 553f4e0fafc5b3b John Stultz     2020-10-03  490         exp_info.name = "system-uncached";
> 553f4e0fafc5b3b John Stultz     2020-10-03  491         exp_info.ops = &system_uncached_heap_ops;
> 553f4e0fafc5b3b John Stultz     2020-10-03  492         exp_info.priv = NULL;
> 553f4e0fafc5b3b John Stultz     2020-10-03  493
> 553f4e0fafc5b3b John Stultz     2020-10-03  494         sys_uncached_heap = dma_heap_add(&exp_info);
> 553f4e0fafc5b3b John Stultz     2020-10-03  495         if (IS_ERR(sys_uncached_heap))
> 553f4e0fafc5b3b John Stultz     2020-10-03 @496                 return PTR_ERR(sys_heap);
>                                                                        ^^^^^^^^^^^^^^^^^
> This should be return PTR_ERR(sys_uncached_heap);

Oh nice! Very impressed that the tool caught that!
Thanks so much for the report! I'll fix it up here shortly.
-john