Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

[Roger Quadros]

Pawel,

On 08/10/2020 06:57, Pawel Laszczak wrote:
> Siergei,
>
> > On 10/7/20 11:15 AM, Roger Quadros wrote:
> >
> > [...]
> > > > Patch removes not used variable 'length' from
> > > > cdns3_wa2_descmiss_copy_data function.
> > > >
> > > > Signed-off-by: Pawel Laszczak <pawell@xxxxxxxxxxx>
> > >
> > > Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
> >
> >    No "commit" is needed here.
>
> Can you explain why?
>
> I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version,
> or because it's only warning - not error.
>
> Am I right ?

Siergei meant that the word "commit" should not be used. So it should be

Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")

cheers,
-roger

> > > Acked-by: Roger Quadros <rogerq@xxxxxx>
> > [...]
>
> Regards,
> Pawel

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki