Re: [PATCH 2/5] x86/boot: Move get_cmd_line_ptr() and COMMAND_LINE_SIZE into misc.h
From: Borislav Petkov
Date: Thu Oct 08 2020 - 05:30:54 EST
On Wed, Oct 07, 2020 at 03:53:48PM -0400, Arvind Sankar wrote:
> Move get_cmd_line_ptr() and COMMAND_LINE_SIZE into misc.h for easier
> use from multiple files.
Well, I don't like that. cmdline.c *is* for cmdline-related things.
misc.h is a dumping ground for everything but the kitchen sink.
Why can't you leave it there and make it visible to other compilation
units?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette