Re: [PATCH 0/7] wfx: move out from the staging area
From: Jérôme Pouiller
Date: Thu Oct 08 2020 - 06:10:18 EST
On Thursday 8 October 2020 09:30:06 CEST Kalle Valo wrote:
[...]
> Yes, the driver needs to be reviewed in linux-wireless list. I recommend
> submitting the whole driver in a patchset with one file per patch, which
> seems to be the easiest way to review a full driver. The final move will
> be in just one commit moving the driver, just like patch 7 does here. As
> an example see how wilc1000 review was done.
I see. I suppose it is still a bit complicated to review? Maybe I could
try to make things easier.
For my submission to staging/ I had taken time to split the driver in an
understandable series of patches[1]. I think it was easier to review than
just sending files one by one. I could do the same thing for the
submission to linux-wireless. It would ask me a bit of work but, since I
already have a template, it is conceivable.
Do you think it is worth it, or it would be an unnecessary effort?
[1] https://lore.kernel.org/driverdev-devel/20190919142527.31797-1-Jerome.Pouiller@xxxxxxxxxx/
or commits a7a91ca5a23d^..40115bbc40e2
--
Jérôme Pouiller