Re: [PATCH] printk: handle blank console arguments passed in.

[Sergey Senozhatsky]

On (20/10/08 11:01), Petr Mladek wrote:
> 
> Interesting idea. Well, it looks like yet another mess:
> 
>   + it would show the consoles in /proc/consoles
>     even thought they will be basically unusable

Which is fine, no? We already can have disables consoles in
/proc/consoles.


$ cat /proc/consoles 
tty0                 -WU ( C p  )    4:1

So tty0 is not 'E'-enabled. I see no problems with that.

These are the flags that /proc/consoles handle

	con_flags[] = {
		{ CON_ENABLED,		'E' },
		{ CON_CONSDEV,		'C' },
		{ CON_BOOT,		'B' },
		{ CON_PRINTBUFFER,	'p' },
		{ CON_BRL,		'b' },
		{ CON_ANYTIME,		'a' },
	};

Why do you think that having disabled consoles in /proc/consoles
is a mess?

> IMHO, we should try to understand why it actually crashes first.
> It might help to solve the problem some cleaner way.

Well, I guess, we have files (either regular files or devices) sitting
in fd-s 0,1,2. God knows what mount/fsck/modprobe can fprintf(), for
instance, to stdout/stderr and what they can corrupt.

	-ss