Re: [PATCH v2 0/5] platform/surface: Create a platform subdirectory for Microsoft Surface devices

[Hans de Goede]

Hi Maximilian,

On 10/5/20 6:03 PM, Maximilian Luz wrote:
> As has come up in the discussion around
>
>    [RFC PATCH] Add support for Microsoft Surface System Aggregator Module
>
> it may make sense to add a Microsoft Surface specific platform
> subdirectory. Andy has suggested drivers/platform/surface for that.
> This series follows said suggestion and creates that subdirectory, as
> well as moves Microsoft Surface related drivers over to it and updates
> their MAINTAINERS entries (if available) accordingly.
>
> This series does not modify any existing driver code, symbols, or help
> text.

In case you do not know I'm taking over from any as
drivers/platform/x86 maintainer.

I'm fine with the concept of this series, but who is going to maintain
this new drivers/platform/surface directory ?

Ah I see that the first patch answers that question and the plan
is to keep this part of the pdx86 maintainership.

I would prefer for the new dir to have its own
MAINTAINERS entry if I'm honest, I would like to try and
split maintainership for the surface stuff as follows:

1. Who will review (and add their Reviewed-by or ask for improvements
   or nack) patches to files in this dir?

2. Who will gather approved patches apply them to a for-next branch
   and send them out to Linus during the merge Window?

I can pick up 2. but I could really use some help with 1. So I
was thinking having a separate MAINTAINERS entry for the new
dir with you (Maximilian) (and me and Mark Gross) listed as
MAINTAINERS; and then I'm hoping that you can do the review
of surface related patches. At least those which you have not
written yourself.

How does that sound ?

Regards,

Hans



> Link to discussion:
>    https://lore.kernel.org/lkml/CAHp75Vfp86h38Rd-VEgER7ASADdmz5ymAkuHvD0Q6WPDqZBqHw@xxxxxxxxxxxxxx/
>
> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>
> Changes in v2:
>   - Rebase onto linux-platform-drivers-x86/for-next to incorporate
>     changes in Maintainer file.
>
> For more details regarding changes, refer to the individual patches.
>
> Maximilian Luz (5):
>    platform: Add Surface platform directory
>    platform/surface: Move Surface 3 WMI driver to platform/surface
>    platform/surface: Move Surface 3 Button driver to platform/surface
>    platform/surface: Move Surface 3 Power OpRegion driver to
>      platform/surface
>    platform/surface: Move Surface Pro 3 Button driver to platform/surface
>
>   MAINTAINERS                                   |  3 +-
>   drivers/platform/Kconfig                      |  2 +
>   drivers/platform/Makefile                     |  1 +
>   drivers/platform/surface/Kconfig              | 49 +++++++++++++++++++
>   drivers/platform/surface/Makefile             | 10 ++++
>   .../platform/{x86 => surface}/surface3-wmi.c  |  0
>   .../{x86 => surface}/surface3_button.c        |  0
>   .../{x86 => surface}/surface3_power.c         |  0
>   .../{x86 => surface}/surfacepro3_button.c     |  0
>   drivers/platform/x86/Kconfig                  | 31 ------------
>   drivers/platform/x86/Makefile                 |  6 ---
>   11 files changed, 64 insertions(+), 38 deletions(-)
>   create mode 100644 drivers/platform/surface/Kconfig
>   create mode 100644 drivers/platform/surface/Makefile
>   rename drivers/platform/{x86 => surface}/surface3-wmi.c (100%)
>   rename drivers/platform/{x86 => surface}/surface3_button.c (100%)
>   rename drivers/platform/{x86 => surface}/surface3_power.c (100%)
>   rename drivers/platform/{x86 => surface}/surfacepro3_button.c (100%)