RE: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted Firmware Service call

[Zulkifli, Muhammad Husaini]

Hi Sudeep,

>-----Original Message-----
>From: Sudeep Holla <sudeep.holla@xxxxxxx>
>Sent: Thursday, October 8, 2020 5:45 PM
>To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@xxxxxxxxx>
>Cc: Hunter, Adrian <adrian.hunter@xxxxxxxxx>; michal.simek@xxxxxxxxxx;
>Shevchenko, Andriy <andriy.shevchenko@xxxxxxxxx>; ulf.hansson@xxxxxxxxxx;
>linux-mmc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx; Raja Subramanian, Lakshmi Bai
><lakshmi.bai.raja.subramanian@xxxxxxxxx>; arnd@xxxxxxxx; Wan Mohamad,
>Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@xxxxxxxxx>
>Subject: Re: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted
>Firmware Service call
>
>On Thu, Oct 08, 2020 at 10:09:33AM +0800,
>muhammad.husaini.zulkifli@xxxxxxxxx wrote:
>> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@xxxxxxxxx>
>>
>> Add header file to handle API function for device driver to
>> communicate with Arm Trusted Firmware.
>
>[nit] Since it moved to trusted-firmware.org, it is no longer "Arm"
>Trusted Firmware. It is now called Trusted Firmware - A profile(TF-A) or
>Trusted Firmware - M profile (TF-M). Please update the subject and the text
>above. I know it is silly but I am being asked to get this fixed as it may create
>"confusion"(I don't know details, please don't ask 😁)
>
>Apart from various minor things Andy already pointed out, this looks good.
>You can add by Ack once the above naming and all things pointed by Andy are
>fixed.

Noted. Thanks Sudeep 😊
>
>--
>Regards,
>Sudeep